docs(client, body): fix doctests failing when certain features are disabled #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctest uses `hyper::Client`, but that is not available unless these features are enabled. This commit adds an attribute to check for those and allows `cargo test` with no arguments to pass again. fixes hyperium#2687.
when testing my fix for hyperium#2687, I noticed that this doctest has the same issue, so here's another fix.
|
Huh, gitcop complained about the commit message subject being too long so I reworded it, but it looks like it's not re-running the check for some reason 😐 |
|
It's OK, gitcop isn't marked required. It's just there as a guide to either nudge people to make a commit message that follows the pattern, or to me to clean up the message when squashing. |
seanmonstar
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes #2687, the second one fixes a very similar issue regarding a client doctest.