fix(http1): return 414 when URI contains more than 65534 characters #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Nov 24, 2021
rajing
force-pushed
the
return-414-code
branch
4 times, most recently
from
f1ea9e4 to
944a5ce
Compare
Previous behavior returned a 404 Bad Request. Conforms to HTTP 1.1 RFC. Closes hyperium#2701
rajing
force-pushed
the
return-414-code
branch
from
944a5ce to
cd56a32
Compare
seanmonstar
reviewed
Nov 29, 2021
seanmonstar
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior returned a 404 Bad Request. Conforms to HTTP 1.1 RFC.
Closes #2701