Skip to content

fix(http1): don't add content-length to head resp #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

fix(http1): don't add content-length to head resp #2836

merged 1 commit into from
May 18, 2022

Conversation

jannes
Copy link
Contributor

@jannes jannes commented May 18, 2022

Head responses should not have content-length implicitly set by hyper.
Fixes #2835

fix(http1): don't add content-length to head resp
a1bbaf5 
Head responses should not have content-length implicitly set by hyper.
seanmonstar
seanmonstar approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding the test!

@seanmonstar seanmonstar merged commit 67b7313 into hyperium:master May 18, 2022
@jannes
Copy link
Contributor Author

jannes commented May 18, 2022

thank you for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server incorrectly adds content-length: 0 to Http1 Head responses
2 participants
@jannes @seanmonstar