Refactor(ffi): remove the "raw" headers option in C API #3002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannasman
force-pushed
the
remove_raw_headers_option_capi
branch
from
752f9aa to
2d2461a
Compare
|
Thanks for the PR! I think we could also remove the related parts in proto... I'm surprised it doesn't give a warning about it being unused in CI. |
|
Oh I see. So the whole raw headers option should be removed (like the title of the issue suggests) not just the functions |
|
Yes, there's no other reason for that internal code to exist. |
Remove the remaining parts related to "raw" headers option.
Fix formatting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Solution proposal for issue #2995.