Skip to content

fix(server): Respect Expect header only when http proto > 1.0 #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(server): Respect Expect header only when http proto > 1.0 #3294

merged 1 commit into from
Aug 23, 2023

Conversation

owarai
Copy link
Contributor

@owarai owarai commented Aug 22, 2023

  1. fix server Expect handling(from the perspective of server correctness)
    Refer to: https://www.rfc-editor.org/rfc/rfc9110.html#name-expect

    A server that receives a 100-continue expectation in an HTTP/1.0 request MUST ignore that expectation

  2. adds HTTP/1.0 Expect 100-continue test

seanmonstar
seanmonstar approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit 43d2f5c into hyperium:master Aug 23, 2023
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
@owarai @0xE282B0
fix(server): Respect Expect header only when http proto > 1.0 (hyperi…
9772dbd 
…um#3294)
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
@owarai @0xE282B0
fix(server): Respect Expect header only when http proto > 1.0 (hyperi…
0310743 
…um#3294)

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@owarai @seanmonstar