feat(error): Error::source() is purposefully unspecified
#3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the exact types returned in the erased errors of `Error::source()` may change at any moment, and cannot be depended on. Closes #2843 BREAKING CHANGE: Do not build any logic depending on the exact types of an `Error::source()`. They are only for debugging.
seanmonstar
force-pushed
the
error-source-unspecified
branch
from
d4adcc3 to
8b57016
Compare
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
…3318) Document that the exact types returned in the erased errors of `Error::source()` may change at any moment, and cannot be depended on. Closes hyperium#2843 BREAKING CHANGE: Do not build any logic depending on the exact types of an `Error::source()`. They are only for debugging.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
…3318) Document that the exact types returned in the erased errors of `Error::source()` may change at any moment, and cannot be depended on. Closes hyperium#2843 BREAKING CHANGE: Do not build any logic depending on the exact types of an `Error::source()`. They are only for debugging. Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that the exact types returned in the erased errors of
Error::source()may change at any moment, and cannot be depended on.Closes #2843
BREAKING CHANGE: Do not build any logic depending on the exact types of
an
Error::source(). They are only for debugging.