fix(http2): initial_max_send_streams defaults to 100
#3538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dswij
approved these changes
Jan 24, 2024
|
We'll merge this after releasing v1.2. |
seanmonstar
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default value of
initial_max_send_streamsto 100, which previously wasusize::MAXas defined inh2crate.This default value can be considered reasonable given that widely-used HTTP/2 client implementations adopt this value such as nghttp2 and Go's x/net/http2, and the HTTP/2 spec recommends that HTTP/2 servers should set
MAX_CONCURRENT_STREAMthey advertise to clients to at least 100. More details can be found at hyperium/h2#731.Continuation of #3524