Skip to content

fix: avoid panic when calling graceful_shutdown if H1 connection was upgraded #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2024
Merged

fix: avoid panic when calling graceful_shutdown if H1 connection was upgraded #3616

merged 2 commits into from
Mar 31, 2024

Conversation

DDtKey
Copy link
Contributor

@DDtKey DDtKey commented Mar 30, 2024 •
edited
Loading

Closes #3615

Added test which fails without these changes

@DDtKey DDtKey changed the title fix: avoid panic of graceful shutdown for finished connection fix: avoid panic on graceful shutdown call for finished H1 connection Mar 30, 2024
@DDtKey DDtKey changed the title fix: avoid panic on graceful shutdown call for finished H1 connection fix: avoid panic when calling graceful_shutdown if H1 connection was upgraded Mar 30, 2024
dswij
dswij approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dswij dswij merged commit 6ecf852 into hyperium:master Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on graceful shutdown for http/1
2 participants
@DDtKey @dswij