Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Pass VC Test Suite #947

Closed
kdimak opened this issue Dec 9, 2019 · 2 comments · Fixed by #981
Closed

Pass VC Test Suite #947

kdimak opened this issue Dec 9, 2019 · 2 comments · Fixed by #981
Assignees
@kdimak
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@kdimak
Copy link
Contributor

kdimak commented Dec 9, 2019 •
edited by troyronda
Loading

Failing tests:

Fail CI checks on test suite failure.
@kdimak kdimak mentioned this issue Dec 9, 2019
Open
26 tasks
@kdimak kdimak changed the title Pass VC Test Suite tests Pass VC Test Suit Dec 10, 2019
@kdimak kdimak changed the title Pass VC Test Suit Pass VC Test Suite Dec 10, 2019
@troyronda troyronda added this to the 0.1.1 milestone Dec 10, 2019
kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 16, 2019
@kdimak
fix: Pass VC Test Suite where JWS is passed as input data
14f9826 
closes hyperledger-aries#947

Signed-off-by: Dima <[email protected]>
@kdimak kdimak mentioned this issue Dec 16, 2019
Merged
@llorllale llorllale added the bug Something isn't working label Dec 17, 2019
kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 17, 2019
@kdimak
fix: Pass VC Test Suite where JWS is passed as input data
3bf7514 
closes hyperledger-aries#947

Signed-off-by: Dima <[email protected]>
kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 17, 2019
@kdimak
fix: Pass VC Test Suite where JWS is passed as input data
d1cfbf6 
closes hyperledger-aries#947

Signed-off-by: Dima <[email protected]>
@kdimak
Copy link
Contributor Author

kdimak commented Dec 18, 2019 •
edited
Loading

2 failing tests remaining:

should be fixed in #992 .
After that, we will be able to send the good looking report to the VC Test Suite.

@troyronda
Copy link
Contributor

Prior to sending the Report, we should see if there is feedback on the JWS signature patch issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdimak kdimak

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

fix: Pass VC Test Suite where JWS is passed as input data kdimak/aries-framework-go
3 participants
@troyronda @llorllale @kdimak