-
Notifications
You must be signed in to change notification settings - Fork 139
Vm trait for reducing code duplication #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
2692982
Started on changing trait
ludfjig 39a7d13
mshv 'working'
ludfjig a003c8a
GDB working again (TODO: entrypoint hardcoded
ludfjig 4dccf79
GDB working on kvm
ludfjig d2d6046
save
ludfjig f317d7d
cleanup
ludfjig b7d2bbc
fix up crashdump
ludfjig 0a536c4
Move files around
ludfjig b5bbe6d
MSHV3 done
ludfjig ec06c04
clippy
ludfjig b4767f1
Merge branch 'main' into vm_trait
ludfjig 7be03b0
Merge branch 'main' into vm_trait
ludfjig e0a5254
fmt
ludfjig 5f9e80f
Windows kinda working
ludfjig 7e02b7e
Windows working
ludfjig ec9c0f7
Merge branch 'main' into vm_trait
ludfjig 300d071
rename some things
ludfjig ad4b41c
Merge branch 'main' into vm_trait
ludfjig de1cb48
Add round trip tests
ludfjig de0acbf
Windows done
ludfjig ca0916f
Fix things
ludfjig 792722e
GOGO
ludfjig 3e822f3
Typos
ludfjig 1156003
No fail fast
ludfjig 2a6e29e
Fix stack guard
ludfjig bb654aa
Fix windows stack guard
ludfjig bbedcab
Fix some referencing of regs
ludfjig 999fa37
Debug CI
ludfjig 31bfc5a
Add debugging logs for testing purpose
ludfjig 39f79d8
Merge branch 'main' into vm_trait
ludfjig fdffe93
Add more debugging
ludfjig a1861df
as_ptr() -> as_ref().as_ptr()
ludfjig c7efb05
More debugging println
ludfjig c2c32c6
Remove tracing from test
ludfjig b181808
Remove comments again
ludfjig 4b19772
Remove half of comments
ludfjig 9b0a88d
Merge branch 'main' into vm_trait
ludfjig d62f533
Remove more comments
ludfjig afd79df
Print name only
ludfjig a9a1e5d
Static + no printing
ludfjig 76fa02b
Some windows cleanup
ludfjig 6c4ca58
Ctrl+c in gdb works on kvm and whp
ludfjig fb4990a
simplify hw logic
ludfjig c9bf37f
Some typos and const cleanup
ludfjig 32a25d2
Fix constant
ludfjig e5303e7
Test static->const again to see if it fails on windows
ludfjig 7e0b1fc
back to static
ludfjig d7bc96c
Merge branch 'main' into vm_trait
ludfjig 5bbc400
Undo testing changes
ludfjig b4398fb
Merge branch 'main' into vm_trait
ludfjig e5f03c2
Remove unused var
ludfjig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're wondering why this was removed, it's because this entire crashdump module is already gated on this