Skip to content

allows tagOverride for helm charts #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2020
Merged

allows tagOverride for helm charts #48

merged 2 commits into from
Nov 30, 2020

Conversation

JBAhire
Copy link
Member

@JBAhire JBAhire commented Nov 27, 2020

Description

addresses hypertrace/hypertrace#55
based on: hypertrace/pinot#18

Testing

Tested with personal EKS cluster deployment by adding following lines in values.yaml for hypertrace deployment.

Works as expected.

Checklist:

  • My changes generate no new warnings
  • [na] I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@JBAhire JBAhire requested a review from a team as a code owner November 27, 2020 06:49
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #48 (2b4f00e) into main (916fef7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #48   +/-   ##
=========================================
  Coverage     82.85%   82.85%           
  Complexity        2        2           
=========================================
  Files             2        2           
  Lines            35       35           
=========================================
  Hits             29       29           
  Misses            6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916fef7...2b4f00e. Read the comment docs.

@JBAhire JBAhire requested a review from ravisingal November 27, 2020 08:38
@JBAhire JBAhire merged commit 5c5ee1f into main Nov 30, 2020
@JBAhire JBAhire deleted the tagoverride-for-helm branch November 30, 2020 04:16
pavan-traceable pushed a commit that referenced this pull request Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants