Skip to content

refactor: migrating to new topology custom metric #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 15, 2021

Description

Please include a summary of the change, motivation and context.
refactor: migrating to new topology custom metric

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #1000 (f1865d8) into main (a75a8f5) will increase coverage by 0.02%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
+ Coverage   85.03%   85.05%   +0.02%     
==========================================
  Files         821      820       -1     
  Lines       16838    16855      +17     
  Branches     2180     2190      +10     
==========================================
+ Hits        14318    14336      +18     
+ Misses       2489     2488       -1     
  Partials       31       31              
Impacted Files Coverage Δ
...api-node-renderer/api-node-box-renderer.service.ts 100.00% <ø> (ø)
...node-renderer/backend-node-box-renderer.service.ts 85.71% <ø> (ø)
...node-renderer/service-node-box-renderer.service.ts 100.00% <ø> (ø)
...ology/node/box/entity-node-box-renderer.service.ts 80.23% <92.85%> (+1.32%) ⬆️
.../pages/apis/topology/application-flow.component.ts 66.66% <100.00%> (+16.66%) ⬆️
...raphql/observability-graphql-data-source.module.ts 100.00% <100.00%> (ø)
...ata/graphql/topology/topology-data-source.model.ts 97.05% <100.00%> (+0.39%) ⬆️
.../edge/curved/entity-edge-curve-renderer.service.ts 100.00% <100.00%> (ø)
...ets/topology/topology-widget-renderer.component.ts 98.03% <100.00%> (+0.12%) ⬆️
.../selections/observability-specification-builder.ts 53.68% <0.00%> (-10.53%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75a8f5...f1865d8. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

jake-bassett
jake-bassett previously approved these changes Jul 16, 2021
Base automatically changed from topology-custom-metric-1 to main July 16, 2021 17:06
@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 185c6fd into main Jul 16, 2021
@anandtiwary anandtiwary deleted the topology-custom-metric-2 branch July 16, 2021 23:01
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   15m 2s ⏱️ - 1m 12s
944 tests ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
951 runs  ±0  951 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 185c6fd. ± Comparison against base commit a75a8f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants