Skip to content

refactor: remove initialize call during registration #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Sep 29, 2021

Description

Please include a summary of the change, motivation and context.
refactor: remove initialize call during registration

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner September 29, 2021 00:51
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1161 (6ef216b) into main (2018fb2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   85.04%   85.04%   -0.01%     
==========================================
  Files         831      831              
  Lines       17208    17207       -1     
  Branches     2235     2235              
==========================================
- Hits        14635    14634       -1     
  Misses       2541     2541              
  Partials       32       32              
Impacted Files Coverage Δ
...ommon/src/telemetry/user-telemetry-impl.service.ts 92.30% <ø> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2018fb2...6ef216b. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit acc8cc4 into main Sep 29, 2021
@anandtiwary anandtiwary deleted the telemetry-followup branch September 29, 2021 01:04
@github-actions
Copy link

Unit Test Results

    4 files  ±0  270 suites  ±0   19m 1s ⏱️ -18s
968 tests ±0  968 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
975 runs  ±0  975 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit acc8cc4. ± Comparison against base commit 2018fb2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants