feat: adding new filter icon #1185
Conversation
| @@ -51,6 +51,7 @@ const iconsRootPath = 'assets/icons'; | |||
| { key: IconType.Eye, url: `${iconsRootPath}/eye.svg` }, | |||
| { key: IconType.FileCode, url: `${iconsRootPath}/file-code.svg` }, | |||
| { key: IconType.Filter, url: `${iconsRootPath}/filter.svg` }, | |||
| { key: IconType.FilterSpecial, url: `${iconsRootPath}/filter-special.svg` }, | |||
There was a problem hiding this comment.
When would we use this filter icon instead of the other one?
There was a problem hiding this comment.
I followed the mocks, should I keep the old filter icon here or replace it with the new-one?
There was a problem hiding this comment.
Where are we using the existing filter icon? Can you share what it looks like?
There was a problem hiding this comment.
We are not using a button. Just in the tables but here a similar example in an input
There was a problem hiding this comment.
Hmm. I could see us needing both as we have different types of filtering, but was curious about the distinction so we could find a better name.
Let's go ahead and merge this with the current name. Once we get a feel for the UX usage, we should rename.
There was a problem hiding this comment.
We could rename the existing one to 'drilldown-filter'. That is the purpose of that icon in the UI now.
There was a problem hiding this comment.
sure @arjunlalb. Icon renamed.
Codecov Report
@@ Coverage Diff @@
## main #1185 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 832 832
Lines 17224 17224
Branches 2239 2239
=======================================
Hits 14645 14645
Misses 2547 2547
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 271 suites 18m 32s ⏱️ Results for commit 4d802d3. |
Description
Adding new filter icon
Testing
Visual testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.