Skip to content

fix: filter out all meta types from table edit columns modal #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

jake-bassett
Copy link
Contributor

Description

This fixes an issue where meta type columns were showing up in the table's add/remove column modal. We've expanded the types of meta columns beyond just $$state and this change augments the filter used to remove these types of columns from the list.

@jake-bassett jake-bassett requested a review from a team as a code owner April 26, 2021 20:38
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #802 (92a5ec7) into main (9ffdc7b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   85.42%   85.41%   -0.02%     
==========================================
  Files         792      792              
  Lines       16176    16178       +2     
  Branches     2063     2063              
==========================================
  Hits        13819    13819              
- Misses       2326     2328       +2     
  Partials       31       31              
Impacted Files Coverage Δ
.../enum/string-enum-table-cell-renderer.component.ts 100.00% <ø> (ø)
...able/columns/table-edit-columns-modal.component.ts 16.66% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffdc7b...92a5ec7. Read the comment docs.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 3b90217 into main Apr 26, 2021
@jake-bassett jake-bassett deleted the ENG-8878-fix-explorer-edit-columns-empty-entry branch April 26, 2021 21:08
@github-actions
Copy link

Unit Test Results

    4 files  250 suites   15m 51s ⏱️
897 tests 897 ✔️ 0 💤 0 ❌
903 runs  903 ✔️ 0 💤 0 ❌

Results for commit 3b90217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants