Skip to content

feat: adding select new display view #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged

feat: adding select new display view #864

merged 1 commit into from
May 19, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented May 19, 2021

Description

Adding select new display view

Testing

Visual Testing

old:
image

new:
image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner May 19, 2021 22:27
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #864 (ecd5127) into main (d08866a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         797      797           
  Lines       16356    16356           
  Branches     1958     1958           
=======================================
  Hits        13971    13971           
  Misses       2353     2353           
  Partials       32       32           
Impacted Files Coverage Δ
projects/components/src/select/select.component.ts 94.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08866a...ecd5127. Read the comment docs.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 1a82260 into main May 19, 2021
@palbizu palbizu deleted the SelectDisplayView branch May 19, 2021 22:38
@anandtiwary
Copy link
Contributor

quick question

Do we also need to apply style changes to menu options ?

That should be gray too right?

I missed it before approving.

@palbizu
Copy link
Contributor Author

palbizu commented May 19, 2021

Should be white. Thanks for the question.

@github-actions
Copy link

Unit Test Results

    4 files  ±0  252 suites  ±0   13m 26s ⏱️ - 1m 28s
908 tests ±0  908 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
914 runs  ±0  914 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1a82260. ± Comparison against base commit d08866a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants