Skip to content

chore: allow ht link to support null from async pipe #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

When used with async pipe, link would error on initial null state.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner June 1, 2021 00:45
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #893 (535c9c2) into main (5143237) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   85.36%   85.37%           
=======================================
  Files         801      801           
  Lines       16472    16475    +3     
  Branches     2067     2067           
=======================================
+ Hits        14062    14065    +3     
  Misses       2378     2378           
  Partials       32       32           
Impacted Files Coverage Δ
projects/components/src/link/link.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5143237...535c9c2. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 47f4f31 into main Jun 1, 2021
@aaron-steinfeld aaron-steinfeld deleted the link-null-support branch June 1, 2021 01:28
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Unit Test Results

    4 files  256 suites   14m 34s ⏱️
923 tests 923 ✔️ 0 💤 0 ❌
929 runs  929 ✔️ 0 💤 0 ❌

Results for commit 47f4f31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants