feat: log marker indicator in the waterfall view #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 85.34% 85.17% -0.18%
==========================================
Files 803 806 +3
Lines 16509 16618 +109
Branches 2074 2088 +14
==========================================
+ Hits 14090 14154 +64
- Misses 2387 2432 +45
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
arjunlalb
reviewed
Jun 3, 2021
projects/components/src/sequence/renderer/sequence-bar-renderer.service.ts
Outdated
Show resolved
Hide resolved
projects/distributed-tracing/src/shared/components/span-detail/span-detail.component.ts
Outdated
Show resolved
Hide resolved
projects/distributed-tracing/src/shared/components/span-detail/span-detail.component.ts
Outdated
Show resolved
Hide resolved
...ibuted-tracing/src/shared/dashboard/widgets/waterfall/waterfall-widget-renderer.component.ts
Outdated
Show resolved
Hide resolved
...rc/shared/dashboard/widgets/waterfall/waterfall/marker-tooltip/marker-tooltip.component.scss
Outdated
Show resolved
Hide resolved
.../src/shared/dashboard/widgets/waterfall/waterfall/marker-tooltip/marker-tooltip.component.ts
Outdated
Show resolved
Hide resolved
.../src/shared/dashboard/widgets/waterfall/waterfall/marker-tooltip/marker-tooltip.component.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arjunlalb
previously approved these changes
Jun 8, 2021
...tributed-tracing/src/shared/dashboard/widgets/waterfall/waterfall/waterfall-chart.service.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jun 9, 2021
projects/components/src/sequence/renderer/sequence-bar-renderer.service.ts
Outdated
Show resolved
Hide resolved
projects/components/src/sequence/renderer/sequence-bar-renderer.service.ts
Outdated
Show resolved
Hide resolved
projects/components/src/sequence/renderer/sequence-bar-renderer.service.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jun 11, 2021
| color: segment.color | ||
| color: segment.color, | ||
| markers: segment.markers | ||
| .map((marker: Marker) => ({ ...marker, markerTime: marker.markerTime - minStart })) |
There was a problem hiding this comment.
nit: some comments would be helpful
anandtiwary
reviewed
Jun 11, 2021
|
|
||
| export interface MarkerDatum { | ||
| marker: Marker; | ||
| origin: ElementRef; |
There was a problem hiding this comment.
If we could use the approach we discussed earlier then that would be great. Mainly, a way to avoid passing an elementRef
There was a problem hiding this comment.
Will take a look in this.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log marker indicator in the waterfall view
Testing
Local testing done.
Checklist:
Log markers
Log-marker-hover
