feat: add filled check circle icon and larger icon size #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jun 9, 2021
| @@ -4,6 +4,7 @@ export const enum IconSize { | |||
| Medium = 'medium', | |||
| Large = 'large', | |||
| ExtraLarge = 'extra-large', | |||
| ExtraLarger = 'extra-larger', | |||
There was a problem hiding this comment.
Oh, and here I was hoping to squeeze in an ExtraMoreLargerest at some point.
anandtiwary
approved these changes
Jun 9, 2021
|
Should we switch to L, XL, XXL etc ? |
Yeah, if we add any more we should move to something else. It's not too bad yet. Dare I say, even a little fun. Any more though and it will be too much. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 803 803
Lines 16509 16509
Branches 2074 2074
=======================================
Hits 14090 14090
Misses 2387 2387
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New icon for a filled checked circle and a larger icon size.