fix: support disabling select options #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 85.04% 85.05%
=======================================
Files 812 812
Lines 16745 16754 +9
Branches 2166 2168 +2
=======================================
+ Hits 14241 14250 +9
Misses 2473 2473
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jul 6, 2021
| @@ -114,7 +114,7 @@ import { SelectSize } from './select-size'; | |||
| *ngFor="let item of items" | |||
| (click)="this.onSelectionChange(item)" | |||
| class="select-option" | |||
| [ngClass]="this.size" | |||
| [ngClass]="this.getStyleClassesForSelectItem(item)" | |||
There was a problem hiding this comment.
Can we avoid the polling? Probably use htMemoize?
There was a problem hiding this comment.
@anandtiwary done.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
itssharmasandeep
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #966
Description
support disabling select options
Testing
Manually tested. UTs added.
Checklist: