Skip to content

feat: support route wise page titles #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

arjunlalb
Copy link
Contributor

Description

Support route wise page titles

Testing

Tested manually. UT added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner July 15, 2021 06:27
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #993 (fbab8e2) into main (5b795c2) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         814      815    +1     
  Lines       16773    16782    +9     
  Branches     2169     2170    +1     
=======================================
+ Hits        14269    14278    +9     
  Misses       2473     2473           
  Partials       31       31           
Impacted Files Coverage Δ
src/app/config.module.ts 0.00% <0.00%> (ø)
projects/common/src/navigation/ht-route.ts 100.00% <100.00%> (ø)
...ojects/common/src/navigation/navigation.service.ts 87.58% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b795c2...fbab8e2. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 96c9d5b into main Jul 15, 2021
@arjunlalb arjunlalb deleted the support-route-wise-title branch July 15, 2021 13:06
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   16m 24s ⏱️ + 1m 34s
942 tests +1  942 ✔️ +1  0 💤 ±0  0 ❌ ±0 
948 runs  +1  948 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 96c9d5b. ± Comparison against base commit 5b795c2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants