Extension building problems

[csillag]

I have tried to build and publish a new test extension, and encountered a bunch of problems.

• when building an extensions which uses the local back-end:
  • when using static assets served from localhost:
    • with webassets.debug set to True, it works. (But it's quite different from what we can push to the web store.)
    • with webassets.debug set to False, I get this error when I try to deploy the extension over a page: GET http://localhost:5000/assets/app.html 404 (Not Found) Other assets are loaded successfully, only this one fails. (Of course this totally breaks the app.) This is problem no. 1.
  • when using bundled assets:
    • with webassets.debug set to True, it fails, because the JS library files are not copied into the extension. This is problem no. 2. (But maybe this is intended, since we are supposed to build with webassets.debug set to False?)
    • with webassets.debug set to False, it works.
• when building an extensions which uses the production back-end:
  • when using bundled assets:
    • with webassets.debug set to False, after deploying it, I get exceptions like this:

TypeError: Cannot read property 'indexOf' of undefined
    at beginsWith (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:3:28748)
    at Object.LocationHtml5Url.$$parse (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:3:29266)
    at $LocationProvider.$get (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:4:1862)
    at Object.invoke (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:2:6901)
    at chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:2:3744
    at getService (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:2:6390)
    at Object.invoke (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:2:6844)
    at chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:2:16343
    at Array.forEach (native)
    at forEach (chrome-extension://lcknipjijijafjbionbfpoehnlfdknhh/public/lib/angular.min.js?0f082d1c:1:2483) 

This might or might not be related to angular/angular.js#4442. (At least the stack trace is the same.) This is problem no. 3

After some debugging, I realized that this is because the URL of the application has changed from https://hypothes.is/app to https://hypothes.is. (So problem no. 3 is solved.)

After using the new URL, I could finally build an extension that has the configuration required for actually pushing it to the chrome web store.

I am leaving this issue here as a memento to fix problem no. 1 and 2.

[tilgovi]

This isn't a bug, it's an enhancement.

Minifying without bundling and vice versa just isn't a supported build configuration.

[csillag]

Trying to use an unsupported configuration ought to result in an error message, instead of a broken build.

[jtremback]

Hopefully contributors can handle an asset pipeline

[tilgovi]

We can also probably support this easily by switching on the asset URL instead of the debug setting.

So, I agree with this report more after thinking about it a minute.

Easy change.