Skip to content

Require space after + and - modifiers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2016
Merged

Require space after + and - modifiers #19

merged 1 commit into from
May 13, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented May 4, 2016

Fixes #18

I hate this modifier syntax, BTW.

@MoOx
Copy link
Collaborator

MoOx commented May 5, 2016

Specs say

Note: While scaling can be specified without any spaces, like lightness(*150%), adding/subtracting must be done with spaces after the +/-, or else the +/- will be interpreted as part of the number by the CSS parser.

So this PR lgtm.

@kinday
Copy link
Collaborator

kinday commented May 13, 2016

Sorry for long response. PR looks good to me. Also thanks for fixing tests and typos.

@kinday kinday added this to the 2.0.0 milestone May 13, 2016
@kinday kinday merged commit 08f8b23 into ianstormtaylor:master May 13, 2016
@taion taion deleted the modifier-space branch May 13, 2016 19:09
@taion
Copy link
Contributor Author

taion commented May 13, 2016

I wonder if it would make sense to have a loose mode.

@taion
Copy link
Contributor Author

taion commented May 13, 2016

(Really more for postcss-color-function, cc @MoOx)

@kinday
Copy link
Collaborator

kinday commented May 13, 2016

I love the way PostCSS approaches the future. The loose mode is not spec-friendly. There will be the day when the feature would shine green but you won’t be able to throw away PostCSS plugin without breaking your code.

@MoOx
Copy link
Collaborator

MoOx commented May 16, 2016

Not a problem for me neither. I will cut a release with a breaking change.

@taion
Copy link
Contributor Author

taion commented Jul 6, 2016

Did this ever get released, BTW?

@tylergaw tylergaw mentioned this pull request Oct 6, 2017
Closed
tylergaw added a commit that referenced this pull request Oct 6, 2017
@tylergaw
Reverts changes made in #19
fb87e23
@tylergaw tylergaw mentioned this pull request Oct 6, 2017
Merged
tylergaw added a commit that referenced this pull request Oct 7, 2017
@tylergaw
Reverts Breaking Changes for a Patch Release (#33)
707ce10 
* Reverts changes made in #19
* Updates history with notes on breaking change releases
tylergaw added a commit that referenced this pull request Oct 7, 2017
@tylergaw
Re-adds changes from #19 that we reverted in #33
6166168
@tylergaw tylergaw mentioned this pull request Oct 7, 2017
Open
This was referenced May 23, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@taion @MoOx @kinday