Skip to content

Worker loader eslint support and documentation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 14, 2019
Merged

Worker loader eslint support and documentation #1

merged 13 commits into from
Oct 14, 2019

Conversation

mattdarveniza
Copy link

Will have to rebase with master to see the meaningful changes.

  • Have added eslint overrides to allow usage of self in *.worker files
  • Added general documentation on usage of works with create-react-app, as well as Typescript specific usage.

@mattdarveniza mattdarveniza changed the title Worker loader Worker loader eslint support and documentation Apr 5, 2019
@mattdarveniza mattdarveniza requested a review from iansu as a code owner April 8, 2019 01:24
@mattdarveniza
Copy link
Author

Alright have merged changes into this so tests pass now, should be good to merge if you're happy with it @iansu

@mattdarveniza mattdarveniza mentioned this pull request Apr 17, 2019
Open
2 tasks
@iansu iansu merged commit 136367c into iansu:worker-loader Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansu iansu Awaiting requested review from iansu iansu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdarveniza @iansu