Eliminate some warnings #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string is terminated by explicit NUL assignement below, use memcpy instead of strncpy.
The documentation sttes that the element size should come second but it's passed first.
There is no point to it being signed other than the trick of negating to record removal. It is compared to unsigned values in a number of places leading to a warning.
output_level is compared to say_level enumeration values which are all non-negative, making the enumeration type unsigned. This comparison triggers a warning.
Property size is compared with file size returned from the stat() call which is signed.
The structures that store nid values store them as unsigned, causing different signedness comparison warnings.
The token value is comparted to an unsigned value, and the string representation is assumed to start with a number, not a sign.
They are compared to an unsigned value causing a different sign comparison warning. These start from zero and only increase, there is no use for negative values.
This avoids different signedness warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of the warnings is signed vs unsigned comparison.
While this is dodgy because there is no clear semantic for such comparison the warning is not all that helpful in itself.
A value can be automatically promoted between signed and unsigned when passed as function argument, for example.