-
Notifications
You must be signed in to change notification settings - Fork 0
Set electrical line length to geographic distance #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
============================================
+ Coverage 21.03% 21.10% +0.07%
- Complexity 54 62 +8
============================================
Files 52 56 +4
Lines 1716 1895 +179
Branches 61 72 +11
============================================
+ Hits 361 400 +39
- Misses 1343 1482 +139
- Partials 12 13 +1
Continue to review full report at Codecov.
|
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. 👍 I partly restructured the code in order to split up files. Logic remains the same. In general there are some minor structural changes that could be addressed, but I don't think its necessary as the overall existing code currently lacks a stringent concept and hence its fine for now to merge this code as well.
Please double check my adaptions before you eventually merge it.
!test |
Partially addresses #8. It's offering a tool to set the electrical line length to the distance of the geographical line string, the line model holds. Will be complemented by #9.