Skip to content

Set electrical line length to geographic distance #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2021

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Dec 12, 2020

Partially addresses #8. It's offering a tool to set the electrical line length to the distance of the geographical line string, the line model holds. Will be complemented by #9.

@ckittl ckittl added the enhancement New feature or request label Dec 12, 2020
@ckittl ckittl requested a review from a team December 12, 2020 13:06
@ckittl ckittl self-assigned this Dec 12, 2020
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #10 (994e139) into master (b4eb19d) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage     21.03%   21.10%   +0.07%     
- Complexity       54       62       +8     
============================================
  Files            52       56       +4     
  Lines          1716     1895     +179     
  Branches         61       72      +11     
============================================
+ Hits            361      400      +39     
- Misses         1343     1482     +139     
- Partials         12       13       +1     
Impacted Files Coverage Δ
...edu/ie3/netpad/grid/controller/GridController.java 39.15% <0.00%> (-1.30%) ⬇️
...n/java/edu/ie3/netpad/menu/ToolMenuController.java 0.00% <0.00%> (ø)
...a/edu/ie3/netpad/grid/info/GridInfoController.java 0.00% <0.00%> (ø)
...edu/ie3/netpad/main/controller/MainController.java 0.00% <0.00%> (ø)
.../main/java/edu/ie3/netpad/tool/ToolController.java
...edu/ie3/netpad/tool/controller/ToolController.java 31.57% <0.00%> (ø)
...3/netpad/tool/event/FixLineLengthRequestEvent.java 0.00% <0.00%> (ø)
...va/edu/ie3/netpad/tool/controller/ToolDialogs.java 0.00% <0.00%> (ø)
...java/edu/ie3/netpad/tool/grid/LineLengthFixer.java 75.51% <0.00%> (ø)
...ie3/netpad/tool/grid/LineLengthResolutionMode.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eb19d...994e139. Read the comment docs.

@ckittl
Copy link
Member Author

ckittl commented Feb 23, 2021

!test

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. 👍 I partly restructured the code in order to split up files. Logic remains the same. In general there are some minor structural changes that could be addressed, but I don't think its necessary as the overall existing code currently lacks a stringent concept and hence its fine for now to merge this code as well.

Please double check my adaptions before you eventually merge it.

@johanneshiry
Copy link
Member

!test

@ckittl ckittl merged commit 7cb5573 into master May 28, 2021
@ckittl ckittl deleted the ck/#8-lineLengthDiscrepancy-toGeographical branch May 28, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants