Skip to content

Introducing scaling function in copy builders #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 18, 2024
Merged

Introducing scaling function in copy builders #1012

merged 12 commits into from
Feb 18, 2024

Conversation

sebastian-peter
Copy link
Member

Closes #1011

Also implementing a bunch of missing copy builders

@sebastian-peter
Introducing scaling function in copy builders
bfc0b97 
Implementing a bunch of missing copy builders
@sebastian-peter sebastian-peter added enhancement New feature or request model Related to the data model (conceptually, not to the implementation) labels Feb 9, 2024
@sebastian-peter sebastian-peter added this to the Version 4.2 milestone Feb 9, 2024
@sebastian-peter sebastian-peter self-assigned this Feb 9, 2024
@sebastian-peter sebastian-peter marked this pull request as draft February 9, 2024 15:23
@sebastian-peter sebastian-peter mentioned this pull request Feb 9, 2024
Closed
@sebastian-peter sebastian-peter marked this pull request as ready for review February 9, 2024 16:23
@sebastian-peter
Copy link
Member Author

sebastian-peter commented Feb 9, 2024 •
edited
Loading

@ reviewers: I'd be happy if you took a closer look into what parameters I do scale and I don't scale here and whether you agree with me!

@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
@sebastian-peter sebastian-peter marked this pull request as draft February 13, 2024 10:13
@sebastian-peter sebastian-peter marked this pull request as ready for review February 13, 2024 13:56
@danielfeismann
Copy link
Member

A more general question. How should we deal with capex? I guess we should scale it for all models as well even this does not represent economy of scale...

danielfeismann
danielfeismann requested changes Feb 17, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me. Just the capex question and one minor thing.

@sebastian-peter
Copy link
Member Author

A more general question. How should we deal with capex? I guess we should scale it for all models as well even this does not represent economy of scale...

I think we should, just to approximate the change. If one looked closely, opex could also reduce while scaling up, but for those precise model changes, one should just properly re-model their scenario.

danielfeismann
danielfeismann approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quickly including capex as well.

@danielfeismann danielfeismann merged commit 8db7e4c into dev Feb 18, 2024
@danielfeismann danielfeismann deleted the sp/#1011-system-participant-scaling branch February 18, 2024 16:28
@sebastian-peter sebastian-peter mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@t-ober t-ober Awaiting requested review from t-ober

@jo-bao jo-bao Awaiting requested review from jo-bao

Assignees

@sebastian-peter sebastian-peter

Labels
enhancement New feature or request model Related to the data model (conceptually, not to the implementation)
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging this pull request may close these issues.

Implement scaling function in system participant inputs
2 participants
@sebastian-peter @danielfeismann