Abstract commonly used functionality from EntitySource.
#1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staudtMarius
added
code quality
…from-EntitySource
…from-EntitySource
Some improvements
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource # Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/datamodel/io/source/IdCoordinateSource.java # src/test/groovy/edu/ie3/datamodel/io/source/IdCoordinateSourceMock.groovy # src/test/groovy/edu/ie3/test/common/WeatherTestData.groovy
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource
…from-EntitySource
…ctionality-from-EntitySource # Conflicts: # CHANGELOG.md
sebastian-peter
requested changes
Jun 13, 2024
There was a problem hiding this comment.
I like your implementation of the issue a lot. This is more than I expected! I just have some minor remarks.
Additionally, please also adapt EntitySourceClassDiagram.puml. If you think that it makes sense, you can leave out protected and private methods there from now on.
src/main/java/edu/ie3/datamodel/io/source/SystemParticipantSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlIdCoordinateSource.java
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSourceTest.groovy
Show resolved
Hide resolved
…ctionality-from-EntitySource # Conflicts: # src/main/java/edu/ie3/datamodel/io/source/ResultEntitySource.java
sebastian-peter
requested changes
Jun 14, 2024
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSourceTest.groovy
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSourceTest.groovy
Outdated
Show resolved
Hide resolved
sebastian-peter
deleted the
ms/#981-abstract-commonly-used-functionality-from-EntitySource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #975
Resolves #981