Skip to content

Improving the usage of streams on SQL fetches. #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Nov 8, 2024
Merged

Improving the usage of streams on SQL fetches. #1062

merged 40 commits into from
Nov 8, 2024

Conversation

staudtMarius
Copy link
Member

Resolves #827

@staudtMarius staudtMarius added java Pull requests that update Java code io Issues relating to input/output labels Apr 9, 2024
@staudtMarius staudtMarius self-assigned this Apr 9, 2024
danielfeismann
danielfeismann previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe Sebastian would like to have a look as well?

sebastian-peter
sebastian-peter requested changes Jun 13, 2024
View reviewed changes
staudtMarius and others added 9 commits June 24, 2024 12:47
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#827-use-java-streams-on-sql-fe…
784c5c4 
…tsches-effectively

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
1cffc66 
…ctively
@staudtMarius
Update CHANGELOG.
3101166
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
710a886 
…ctively
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
538906c 
…ctively
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
75538a0 
…ctively
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
09d581b 
…ctively
@staudtMarius
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
81ef0e1 
…ctively
@sebastian-peter
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
a398154 
…ctively

# Conflicts:
#	CHANGELOG.md
sebastian-peter
sebastian-peter requested changes Oct 25, 2024
View reviewed changes
Marius Staudt and others added 4 commits November 5, 2024 08:36
Merge branch 'dev' into ms/#827-use-java-streams-on-sql-fetsches-effe…
55374c4 
…ctively

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/connectors/SqlConnector.java
#	src/main/java/edu/ie3/datamodel/io/source/sql/SqlDataSource.java
@staudtMarius
Small improvements.
61e7ca3
@staudtMarius
Fixing failing sql test.
357de53
@staudtMarius
Adding missing import in SqlSinkTest.
1937279
sebastian-peter
sebastian-peter requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now and it seems to work. One more request from my side

sebastian-peter
sebastian-peter approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some last tinkering

@sebastian-peter sebastian-peter merged commit 2e1c2c9 into dev Nov 8, 2024
3 checks passed
@sebastian-peter sebastian-peter deleted the ms/#827-use-java-streams-on-sql-fetsches-effectively branch November 8, 2024 18:06
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

Assignees

@staudtMarius staudtMarius

Labels
io Issues relating to input/output java Pull requests that update Java code
Projects
None yet
Milestone
Version 6.0
Development

Successfully merging this pull request may close these issues.

Use Java streams on SQL fetches effectively
3 participants
@staudtMarius @sebastian-peter @danielfeismann