Skip to content

Enhancing VoltageLevel with equals method. #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2024
Merged

Enhancing VoltageLevel with equals method. #1064

merged 5 commits into from
Apr 12, 2024

Conversation

staudtMarius
Copy link
Member

Resolves #1063

@staudtMarius staudtMarius added the enhancement New feature or request label Apr 9, 2024
@staudtMarius staudtMarius self-assigned this Apr 9, 2024
sebastian-peter
sebastian-peter requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide an implementation for a hashcode method, as equals and hashcode should always be provided in combination. Intellij offers some nice auto-generated implementations.

@staudtMarius
Copy link
Member Author

Please also provide an implementation for a hashcode method, as equals and hashcode should always be provided in combination. Intellij offers some nice auto-generated implementations.

Now there are also added.

sebastian-peter
sebastian-peter approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine if we do not compare some fields like ids here. However, I fixed the equals method of CommonVoltageLevel, which did not call the equals method of the super class before.

@sebastian-peter sebastian-peter merged commit ffe05f0 into dev Apr 12, 2024
@sebastian-peter sebastian-peter deleted the ms/#1063-enhance-VoltageLevel-with-equals-method branch April 12, 2024 13:27
@staudtMarius staudtMarius mentioned this pull request Apr 15, 2024
Closed
@sebastian-peter sebastian-peter added this to the Version 5.1 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.1
Development

Successfully merging this pull request may close these issues.

Enhance VoltageLevel with equals method
2 participants
@staudtMarius @sebastian-peter