Skip to content

Extend ValidationUtils for validating ThermalGrids #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 30, 2025
Merged

Extend ValidationUtils for validating ThermalGrids #1217

merged 7 commits into from
Jan 30, 2025

Conversation

danielfeismann
Copy link
Member

resolves #1216

@danielfeismann danielfeismann self-assigned this Jan 22, 2025
@danielfeismann danielfeismann added the enhancement New feature or request label Jan 22, 2025
@danielfeismann danielfeismann mentioned this pull request Jan 22, 2025
Merged
@danielfeismann danielfeismann marked this pull request as ready for review January 22, 2025 16:48
@danielfeismann danielfeismann mentioned this pull request Jan 22, 2025
Merged
staudtMarius
staudtMarius requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small remarks.

staudtMarius
staudtMarius requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks in the new test.

staudtMarius
staudtMarius approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@staudtMarius staudtMarius merged commit a1ab6f5 into dev Jan 30, 2025
3 checks passed
@staudtMarius staudtMarius deleted the df/#1216-ValidationUtils-for-validating-ThermalGrids branch January 30, 2025 13:25
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 6.0
Development

Successfully merging this pull request may close these issues.

Extend ValidationUtils for validating ThermalGrids
3 participants
@danielfeismann @staudtMarius @sebastian-peter