Skip to content

Replaced LoadProfileInput with LoadProfileTimeSeries #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 6, 2025
Merged

Replaced LoadProfileInput with LoadProfileTimeSeries #1229

merged 5 commits into from
Feb 6, 2025

Conversation

staudtMarius
Copy link
Member

Resolves #1228

@staudtMarius staudtMarius mentioned this pull request Feb 3, 2025
Merged
@staudtMarius staudtMarius self-assigned this Feb 4, 2025
danielfeismann
danielfeismann requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some questions and I'm not sure if I got the reason for these changes. Maybe we can have a talk the next days to get me on the same level, thanks :)

danielfeismann
danielfeismann reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for checking my questions. Could you please have a look to the sonarQube issues and then where are good to go from my side

danielfeismann
danielfeismann approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit dcc1850 into dev Feb 6, 2025
3 checks passed
@danielfeismann danielfeismann deleted the ms/#1228-refactor-LoadProfileTimeSeries branch February 6, 2025 17:03
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@staudtMarius staudtMarius

Labels
None yet
Projects
None yet
Milestone
Version 6.0
Development

Successfully merging this pull request may close these issues.

Replace LoadProfileInput with LoadProfileTimeSeries
3 participants
@staudtMarius @danielfeismann @sebastian-peter