Skip to content

Added RandomLoadProfileTimeSeries #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 19, 2025

Conversation

staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Feb 3, 2025

Resolves #1232

This branch is build on top of #1231.

@staudtMarius
Copy link
Member Author

I think we can ignore the sonarqube issues regarding the random number generator, since we do not use the generated number in a security-sensitive case (see here).

@danielfeismann
Copy link
Member

Yes, but please have a look if you could reduce the number of duplicated lines.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts from my side.

Another thing: Should we / can we check the profiles (random, but also the others we included) with SystemParticipantValidationUtils.checkLoad() ?

@staudtMarius
Copy link
Member Author

staudtMarius commented Feb 18, 2025

@danielfeismann We do check the load profile in SystemParticipantValidationUtils.checkLoad():

image

@danielfeismann
Copy link
Member

@danielfeismann We do check the load profile in SystemParticipantValidationUtils.checkLoad():

Yes, I know. I just wanted to ask if we apply this validation as well to the loadProfiles within your tests.

@staudtMarius
Copy link
Member Author

@danielfeismann We do check the load profile in SystemParticipantValidationUtils.checkLoad():

Yes, I know. I just wanted to ask if we apply this validation as well to the loadProfiles within your tests.

What do you mean with within your tests?

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit db68a2c into dev Feb 19, 2025
3 checks passed
@danielfeismann danielfeismann deleted the ms/#1232-add-RandomLoadProfileTimeSeries branch February 19, 2025 08:25
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RandomLoadProfileTimeSeries
3 participants