-
Notifications
You must be signed in to change notification settings - Fork 5
Added RandomLoadProfileTimeSeries
#1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RandomLoadProfileTimeSeries
#1233
Conversation
I think we can ignore the |
Yes, but please have a look if you could reduce the number of duplicated lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts from my side.
Another thing: Should we / can we check the profiles (random, but also the others we included) with SystemParticipantValidationUtils.checkLoad() ?
src/main/java/edu/ie3/datamodel/io/factory/timeseries/RandomLoadProfileFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileTimeSeries.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileTimeSeries.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/value/load/RandomLoadValues.java
Outdated
Show resolved
Hide resolved
@danielfeismann We do check the load profile in |
Yes, I know. I just wanted to ask if we apply this validation as well to the loadProfiles within your tests. |
What do you mean with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #1232
This branch is build on top of #1231.