Skip to content

Add Attributes housingType and numberInhabitants to ThermalHouses #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 24, 2025
Merged

Add Attributes housingType and numberInhabitants to ThermalHouses #1254

merged 5 commits into from
Feb 24, 2025

Conversation

danielfeismann
Copy link
Member

resolves #1253

@danielfeismann danielfeismann added enhancement New feature or request model Related to the data model (conceptually, not to the implementation) labels Feb 21, 2025
@danielfeismann danielfeismann self-assigned this Feb 21, 2025
@danielfeismann danielfeismann marked this pull request as ready for review February 21, 2025 15:56
staudtMarius
staudtMarius requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small remarks.

staudtMarius
staudtMarius requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small remarks.

@danielfeismann danielfeismann mentioned this pull request Feb 24, 2025
Merged
staudtMarius
staudtMarius approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your work.

@staudtMarius staudtMarius merged commit 04c692d into dev Feb 24, 2025
3 checks passed
@staudtMarius staudtMarius deleted the df/#1253-housingType-and-numberInhabitants branch February 24, 2025 13:15
@sebastian-peter sebastian-peter added this to the Version 6.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels
enhancement New feature or request model Related to the data model (conceptually, not to the implementation)
Projects
None yet
Milestone
Version 6.0
Development

Successfully merging this pull request may close these issues.

Add Attributes housingType and numberInhabitants to ThermalHouses
3 participants
@danielfeismann @staudtMarius @sebastian-peter