Misleading parameter name 'height' has changed to 'elevationAngle'

[muradiodev]

Misleading parameter name 'height' has changed to 'elevationAngle'

resolves #393

[ckittl]

PowerSystemDataModel/gradle/scripts/tests.gradle

Line 4 in b1cd187

events "skipped", "failed", "passed"

If you might change the list to "skipped", "failed", the log file won't be blown up by entries for tests, that are passing.

[ckittl]

PowerSystemDataModel/gradle/scripts/tests.gradle

Line 4 in b1cd187

events "skipped", "failed", "passed"

If you might change the list to "skipped", "failed", the log file won't be blown up by entries for tests, that are passing.

Nevermind, I already brought it in from another PR.

[codecov]

Codecov Report

Merging #443 (222460d) into dev (b0cfa27) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #443      +/-   ##
============================================
+ Coverage     77.63%   77.76%   +0.12%     
+ Complexity     2137     2136       -1     
============================================
  Files           271      271              
  Lines          8505     8459      -46     
  Branches        806      806              
============================================
- Hits           6603     6578      -25     
+ Misses         1496     1483      -13     
+ Partials        406      398       -8     

Impacted Files	Coverage Δ
...edu/ie3/datamodel/models/input/AssetTypeInput.java	70.00% <0.00%> (-2.73%)	⬇️
...model/models/input/container/SubGridContainer.java	69.23% <0.00%> (-2.20%)	⬇️
...atamodel/models/input/container/GridContainer.java	52.17% <0.00%> (-2.00%)	⬇️
...tamodel/models/input/thermal/ThermalUnitInput.java	62.50% <0.00%> (-1.50%)	⬇️
...del/models/input/container/JointGridContainer.java	75.00% <0.00%> (-1.20%)	⬇️
...amodel/models/input/graphics/LineGraphicInput.java	83.33% <0.00%> (-0.88%)	⬇️
.../datamodel/models/input/graphics/GraphicInput.java	76.92% <0.00%> (-0.86%)	⬇️
...tamodel/models/input/connector/ConnectorInput.java	64.28% <0.00%> (-0.84%)	⬇️
...edu/ie3/datamodel/models/input/system/EvInput.java	79.41% <0.00%> (-0.59%)	⬇️
...du/ie3/datamodel/models/input/system/WecInput.java	75.60% <0.00%> (-0.59%)	⬇️
... and 40 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605898f...222460d. Read the comment docs.

[ckittl]

Please also add a remark in CHANGELOG.md, that describes the changes and that does warn about the fact, that these changes are breaking! You may have a look at the description of the changed transformer parameter interpretation.

[danielfeismann]

Please also add a remark in CHANGELOG.md, that describes the changes and that does warn about the fact, that these changes are breaking! You may have a look at the description of the changed transformer parameter interpretation.

done

[sonarqubegithubprchecks]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 84.21% Coverage (77.10% Estimated after merge)
• 0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube