Skip to content

Reduce code smells #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 6, 2022
Merged

Reduce code smells #493

merged 13 commits into from
Jan 6, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 6, 2022

Resolves #492

@ckittl ckittl self-assigned this Jan 6, 2022
@ckittl ckittl added the bug Something isn't working label Jan 6, 2022
@ckittl ckittl mentioned this pull request Jan 6, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #493 (4aa6394) into dev (32168aa) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #493      +/-   ##
============================================
- Coverage     78.91%   78.78%   -0.14%     
+ Complexity     2111     2083      -28     
============================================
  Files           261      261              
  Lines          8230     8212      -18     
  Branches        775      777       +2     
============================================
- Hits           6495     6470      -25     
- Misses         1344     1348       +4     
- Partials        391      394       +3     
Impacted Files Coverage Δ
...o/factory/input/participant/HpInputEntityData.java 63.15% <0.00%> (-15.42%) ⬇️
...java/edu/ie3/datamodel/io/extractor/Extractor.java 78.94% <0.00%> (-7.90%) ⬇️
...tamodel/models/input/system/type/ChpTypeInput.java 69.23% <0.00%> (-3.85%) ⬇️
.../ie3/datamodel/io/csv/FileNameMetaInformation.java 66.66% <0.00%> (-3.34%) ⬇️
...du/ie3/datamodel/io/processor/EntityProcessor.java 82.14% <0.00%> (-1.73%) ⬇️
...del/io/processor/result/ResultEntityProcessor.java 89.47% <0.00%> (-1.44%) ⬇️
...java/edu/ie3/datamodel/io/processor/Processor.java 87.82% <0.00%> (-0.51%) ⬇️
...ain/java/edu/ie3/datamodel/io/factory/Factory.java 87.50% <0.00%> (-0.50%) ⬇️
...n/java/edu/ie3/datamodel/io/sink/InfluxDbSink.java 80.37% <0.00%> (-0.37%) ⬇️
...in/java/edu/ie3/datamodel/io/sink/CsvFileSink.java 72.89% <0.00%> (-0.33%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9595253...4aa6394. Read the comment docs.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

9 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell9 Code Smells

Coverage and Duplications

  • 60 percent coverage88.07% Coverage (77.80% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@ckittl ckittl requested a review from a team January 6, 2022 15:43
@ckittl ckittl marked this pull request as ready for review January 6, 2022 15:44
@ckittl
Copy link
Member Author

ckittl commented Jan 6, 2022

Dunno, if this is sufficient to lower the amount of code smells (Sonarqube only uncovers this after the PR is merged).

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-peter sebastian-peter merged commit 04db918 into dev Jan 6, 2022
@sebastian-peter sebastian-peter deleted the ck/#492-reducingCodeSmells branch January 6, 2022 22:10
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce code smells
2 participants