-
Notifications
You must be signed in to change notification settings - Fork 5
Reduce code smells #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code smells #493
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #493 +/- ##
============================================
- Coverage 78.91% 78.78% -0.14%
+ Complexity 2111 2083 -28
============================================
Files 261 261
Lines 8230 8212 -18
Branches 775 777 +2
============================================
- Hits 6495 6470 -25
- Misses 1344 1348 +4
- Partials 391 394 +3
Continue to review full report at Codecov.
|
…ells # Conflicts: # src/main/java/edu/ie3/datamodel/io/source/sql/SqlWeatherSource.java
Analysis Details9 IssuesCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel |
Dunno, if this is sufficient to lower the amount of code smells (Sonarqube only uncovers this after the PR is merged). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #492