Resolving issue #378- Check ValidationUtils for negative Susceptance

[Utkarsha-dev05]

Adapting ValidationUtils and test data such that only negative values are allowed for the transformer susceptance.

[ckittl]

Closes #378

[ckittl]

Please additionally check the CI results. Currently some tests are broken.

[codecov]

Codecov Report

Merging #499 (bb8a6a1) into dev (89d894e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #499      +/-   ##
============================================
- Coverage     78.89%   78.88%   -0.01%     
+ Complexity     2107     2106       -1     
============================================
  Files           263      263              
  Lines          8273     8275       +2     
  Branches        780      780              
============================================
+ Hits           6527     6528       +1     
- Misses         1345     1350       +5     
+ Partials        401      397       -4     

Impacted Files	Coverage Δ
...atamodel/models/input/system/type/BmTypeInput.java	73.68% <0.00%> (-5.27%)	⬇️
.../models/input/thermal/CylindricalStorageInput.java	85.24% <0.00%> (-1.64%)	⬇️
...e3/datamodel/utils/validation/ValidationUtils.java	94.17% <0.00%> (-0.83%)	⬇️
...del/utils/validation/ConnectorValidationUtils.java	87.57% <0.00%> (-0.08%)	⬇️
...atamodel/models/input/system/type/EvTypeInput.java	73.68% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java	69.23% <0.00%> (ø)
...datamodel/io/naming/DefaultDirectoryHierarchy.java	93.96% <0.00%> (+0.86%)	⬆️
...tamodel/models/input/system/type/ChpTypeInput.java	73.07% <0.00%> (+3.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497f7c8...bb8a6a1. Read the comment docs.

[ckittl]

Generally looks good! Only some minor change requests regarding the documentation :-)

[sonarqubegithubprchecks]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 88.89% Coverage (77.90% Estimated after merge)
• 0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube