Skip to content

Refactoring TimeSeriesTypeSource and cleaning up CsvFileConnector #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 31, 2022

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Mar 16, 2022

Resolves #565 and #544

  • Refactoring TimeSeriesTypeSource to TimeSeriesMetaInformationSource
  • Merging IndividualTimeSeriesMetaInformation and TypeEntry
  • Re-introducing TimeSeriesMetaInformationSource#getTimeSeriesMetaInformation(UUID)
  • Saving retrieved time series meta information in CsvTimeSeriesMetaInformationSource instead of CsvFileConnector
  • Clean up CsvFileConnector #544
  • Removing deprecated SQLs from test resources
  • Adapting CHANGELOG

Re-introducing #getTimeSeriesMetaInformation(UUID)
Removing TypeEntry
@sebastian-peter sebastian-peter added the code quality Code readability or structure is improved label Mar 16, 2022
@sebastian-peter sebastian-peter self-assigned this Mar 16, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #566 (37db9b0) into dev (37a7307) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #566      +/-   ##
============================================
+ Coverage     78.07%   78.17%   +0.10%     
+ Complexity     2170     2167       -3     
============================================
  Files           281      280       -1     
  Lines          8537     8499      -38     
  Branches        808      801       -7     
============================================
- Hits           6665     6644      -21     
+ Misses         1478     1464      -14     
+ Partials        394      391       -3     
Impacted Files Coverage Δ
...tamodel/models/input/system/type/ChpTypeInput.java 72.00% <0.00%> (-4.00%) ⬇️
.../ie3/datamodel/io/connectors/CsvFileConnector.java 67.85% <0.00%> (-0.82%) ⬇️
.../ie3/datamodel/io/source/csv/CsvWeatherSource.java 76.25% <0.00%> (-0.58%) ⬇️
...3/datamodel/io/source/TimeSeriesMappingSource.java 50.00% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 72.00% <0.00%> (ø)
...tamodel/io/source/sql/SqlTimeSeriesTypeSource.java
.../ie3/datamodel/io/source/TimeSeriesTypeSource.java
...l/io/factory/timeseries/TimeSeriesTypeFactory.java
...tamodel/io/source/csv/CsvTimeSeriesTypeSource.java
...y/timeseries/TimeSeriesMetaInformationFactory.java 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8722f17...37db9b0. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter marked this pull request as ready for review March 17, 2022 22:51
@sebastian-peter sebastian-peter requested a review from t-ober March 17, 2022 22:51
@sebastian-peter sebastian-peter changed the title Refactoring TimeSeriesTypeSource Refactoring TimeSeriesTypeSource and cleaning up CsvFileConnector Mar 17, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter requested a review from a team March 18, 2022 14:23
@sebastian-peter sebastian-peter linked an issue Apr 5, 2022 that may be closed by this pull request
@sonarqubegithubprchecks

This comment has been minimized.

1 similar comment
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 90 percent coverage97.06% Coverage (77.30% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.50% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the work. Looks good to me :)

@danielfeismann danielfeismann merged commit 35bc117 into dev Jul 31, 2022
@danielfeismann danielfeismann deleted the sp/#565-restructure-timeseries-meta-information branch July 31, 2022 09:31
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or structure is improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate TypeEntry and IndividualTimeSeriesMetaInformation Clean up CsvFileConnector
2 participants