-
Notifications
You must be signed in to change notification settings - Fork 5
Refactoring TimeSeriesTypeSource
and cleaning up CsvFileConnector
#566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring TimeSeriesTypeSource
and cleaning up CsvFileConnector
#566
Conversation
Re-introducing #getTimeSeriesMetaInformation(UUID) Removing TypeEntry
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #566 +/- ##
============================================
+ Coverage 78.07% 78.17% +0.10%
+ Complexity 2170 2167 -3
============================================
Files 281 280 -1
Lines 8537 8499 -38
Branches 808 801 -7
============================================
- Hits 6665 6644 -21
+ Misses 1478 1464 -14
+ Partials 394 391 -3
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TimeSeriesTypeSource
and cleaning up CsvFileConnector
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesMetaInformationSourceIT.groovy
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # CHANGELOG.md
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the work. Looks good to me :)
Resolves #565 and #544
TimeSeriesTypeSource
toTimeSeriesMetaInformationSource
IndividualTimeSeriesMetaInformation
andTypeEntry
TimeSeriesMetaInformationSource#getTimeSeriesMetaInformation(UUID)
CsvTimeSeriesMetaInformationSource
instead ofCsvFileConnector
CsvFileConnector
#544