Skip to content

To/#637 groovy spotless #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2022
Merged

To/#637 groovy spotless #638

merged 8 commits into from
Aug 9, 2022

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Aug 2, 2022

Resolves #637

@t-ober t-ober requested a review from sebastian-peter August 2, 2022 14:41
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #638 (8708b90) into dev (594232b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #638      +/-   ##
============================================
+ Coverage     78.18%   78.19%   +0.01%     
- Complexity     2188     2190       +2     
============================================
  Files           284      284              
  Lines          8564     8564              
  Branches        793      793              
============================================
+ Hits           6696     6697       +1     
+ Misses         1482     1480       -2     
- Partials        386      387       +1     
Impacted Files Coverage Δ
.../models/input/thermal/CylindricalStorageInput.java 86.66% <0.00%> (-1.67%) ⬇️
...s/input/connector/type/Transformer3WTypeInput.java 72.05% <0.00%> (-1.48%) ⬇️
...atamodel/models/input/system/type/EvTypeInput.java 77.77% <0.00%> (ø)
...del/models/input/system/type/StorageTypeInput.java 71.42% <0.00%> (ø)
...tamodel/models/input/system/type/ChpTypeInput.java 76.00% <0.00%> (+4.00%) ⬆️
...atamodel/models/input/system/type/BmTypeInput.java 83.33% <0.00%> (+5.55%) ⬆️
...atamodel/models/input/system/type/HpTypeInput.java 81.25% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@t-ober t-ober requested review from a team and removed request for sebastian-peter August 2, 2022 17:28
t-ober and others added 3 commits August 4, 2022 07:47
# Conflicts:
#	src/test/groovy/edu/ie3/datamodel/io/csv/CsvFileDefinitionTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/naming/EntityPersistenceNamingStrategyTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/processor/ProcessorProviderTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/processor/timeseries/TimeSeriesProcessorTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvSystemParticipantSourceTest.groovy
#	src/test/groovy/edu/ie3/datamodel/models/input/container/JointGridContainerTest.groovy
#	src/test/groovy/edu/ie3/datamodel/models/input/container/SystemParticipantsTest.groovy
#	src/test/groovy/edu/ie3/datamodel/utils/ContainerUtilsTest.groovy
#	src/test/groovy/edu/ie3/test/common/ComplexTopology.groovy
#	src/test/groovy/edu/ie3/test/common/SampleJointGrid.groovy
#	src/test/groovy/edu/ie3/test/common/SystemParticipantTestData.groovy
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great that this finally works.
I am wondering if there's a way to apply spotless to Jenkinsfile as well, but I haven't found a way yet.

So there's only this minor point below that you might consider

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastian-peter sebastian-peter merged commit 51bd735 into dev Aug 9, 2022
@sebastian-peter sebastian-peter deleted the to/#637-groovy-spotless branch August 9, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix groovy spotless formatting
2 participants