Skip to content

persist em input #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 21, 2022
Merged

persist em input #666

merged 7 commits into from
Sep 21, 2022

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Sep 19, 2022

resolves #665

t-ober and others added 6 commits September 19, 2022 08:21
Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
This reverts commit 492fdfe
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 78.16% // Head: 78.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6c86c8c) compared to base (4636176).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #666   +/-   ##
=========================================
  Coverage     78.16%   78.16%           
  Complexity     2206     2206           
=========================================
  Files           287      287           
  Lines          8627     8629    +2     
  Branches        800      800           
=========================================
+ Hits           6743     6745    +2     
  Misses         1498     1498           
  Partials        386      386           
Impacted Files Coverage Δ
...atamodel/models/input/system/type/EvTypeInput.java 77.77% <0.00%> (ø)
...del/models/input/system/type/StorageTypeInput.java 71.42% <0.00%> (ø)
...del/models/input/container/SystemParticipants.java 92.15% <0.00%> (+0.05%) ⬆️
...in/java/edu/ie3/datamodel/io/sink/CsvFileSink.java 72.89% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's go

@sebastian-peter sebastian-peter merged commit 456115d into dev Sep 21, 2022
@sebastian-peter sebastian-peter deleted the to/#665-persist-em-input branch September 21, 2022 17:55
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmInputs do not seem to be persist upon calling persistJointGrid on a CSV file sink
2 participants