SQL source for weather coordinates using PostGIS #694

staudtMarius · 2022-10-27T09:51:13Z

Resolves #689

…ateSource

sonatype-lift · 2022-10-27T10:10:04Z

⚠️ 5 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

…-of-ÍdCoordinateSource' into ms/#689-improving-implementation-of-ÍdCoordinateSource

Adding to CHANGELOG.

sebastian-peter

This is my first quick review. Please hit me up if you have any questions.

src/main/java/edu/ie3/datamodel/io/source/sql/SqlIdCoordinateSource.java

…ateSource

Implementing some requests.

Adding some tests.

…ateSource

Fixing some failing tests.

sebastian-peter

I wrote these comments before I thought about exploring PostGIS, so it might make sense to explore that before looking through some comments

src/main/java/edu/ie3/datamodel/io/source/IdCoordinateSource.java

src/test/groovy/edu/ie3/datamodel/io/source/IdCoordinateSourceTest.groovy

src/test/resources/edu/ie3/datamodel/io/source/sql/_coordinates/icon/coordinates.sql

src/main/java/edu/ie3/datamodel/io/source/IdCoordinateSource.java

src/main/java/edu/ie3/datamodel/io/factory/timeseries/IdCoordinateFactory.java

…ateSource

…ateSource # Conflicts: # docs/readthedocs/models/models.rst

…ateSource

sebastian-peter · 2023-04-24T12:20:55Z

!test

src/main/java/edu/ie3/datamodel/io/source/IdCoordinateSource.java

docs/readthedocs/io/source/idcoordinatesource.md

docs/readthedocs/io/csvfiles.md

src/main/java/edu/ie3/datamodel/io/factory/timeseries/SqlCoordinateFactory.java

…ateSource

staudtMarius · 2023-05-02T11:52:40Z

!test

docs/readthedocs/conf.py

docs/readthedocs/io/basiciousage.rst

…ateSource

…ateSource # Conflicts: # CHANGELOG.md

…ateSource

docs/readthedocs/conf.py

sebastian-peter

Think we're getting closer!

docs/readthedocs/io/csvfiles.md

docs/readthedocs/models/input/additionaldata/idcoordinatesource.md

src/main/java/edu/ie3/datamodel/io/factory/timeseries/SqlCoordinateFactory.java

src/test/groovy/edu/ie3/test/common/WeatherTestData.groovy

sebastian-peter

Ok, we got it done! Thanks!

Improving implementation of idCoordinateSource.

22a6fee

Resolves #689

staudtMarius added the enhancement New feature or request label Oct 27, 2022

staudtMarius self-assigned this Oct 27, 2022

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

116d351

…ateSource

staudtMarius added 4 commits October 28, 2022 10:45

Improving code.

acf9a5d

Merge remote-tracking branch 'origin/ms/#689-improving-implementation…

e424f0d

…-of-ÍdCoordinateSource' into ms/#689-improving-implementation-of-ÍdCoordinateSource

fmt

6e8025c

Adding some documentation.

d879543

Adding to CHANGELOG.

sebastian-peter requested changes Oct 30, 2022

View reviewed changes

staudtMarius and others added 10 commits October 31, 2022 11:29

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

a2d2faf

…ateSource

Implementing some tests.

d4d3156

Implementing some requests.

Adding missing file for SqlIdCoordinateSource test.

00c21f2

fmt

a19ff9f

fmt

354fc4a

fmt

9b59372

Some refactoring.

344d6fb

Adding some tests.

Implementing changes in CsvIdCoordinateSource.

2644931

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

c83873b

…ateSource

Adding some tests.

f0ca780

Fixing some failing tests.

staudtMarius marked this pull request as ready for review November 7, 2022 12:54

staudtMarius requested a review from sebastian-peter November 7, 2022 12:54

sebastian-peter requested changes Nov 7, 2022

View reviewed changes

staudtMarius added 3 commits November 8, 2022 09:08

Adding requested changes.

529bee2

Adding requested changes.

9613ba9

SqlIdCoordinateSource uses PostGis now.

42ff465

staudtMarius requested a review from sebastian-peter November 15, 2022 16:52

sonatype-lift bot reviewed Nov 15, 2022

View reviewed changes

src/main/java/edu/ie3/datamodel/io/factory/timeseries/IdCoordinateFactory.java Outdated Show resolved Hide resolved

Fixing test problems.

975fa09

sonatype-lift bot reviewed Nov 15, 2022

View reviewed changes

src/main/java/edu/ie3/datamodel/io/factory/timeseries/IdCoordinateFactory.java Outdated Show resolved Hide resolved

staudtMarius and others added 2 commits April 14, 2023 10:49

Implementing requested changes.

45d10ab

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

71e02e3

…ateSource

staudtMarius requested a review from sebastian-peter April 18, 2023 09:43

sebastian-peter requested a review from jo-bao April 19, 2023 11:25

staudtMarius and others added 3 commits April 24, 2023 11:56

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

bc1c713

…ateSource # Conflicts: # docs/readthedocs/models/models.rst

fmt

5e19cd6

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

13bbc45

…ateSource

sebastian-peter added 2 commits April 24, 2023 15:45

Indentation

a3455c0

Updating readthedocs online build config

377cc32

sebastian-peter requested changes Apr 24, 2023

View reviewed changes

staudtMarius and others added 4 commits April 27, 2023 15:01

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

cabc9f0

…ateSource

Implementing requested changes.

64f17b3

Fixing documentation issues.

6885b36

Fixing documentation issues.

5f124b0

staudtMarius requested a review from sebastian-peter May 2, 2023 11:57

sebastian-peter requested changes May 2, 2023

View reviewed changes

staudtMarius and others added 2 commits May 4, 2023 13:58

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

78e3aa2

…ateSource

Implementing requested documentation changes.

85ae7f0

staudtMarius requested a review from sebastian-peter May 4, 2023 12:32

staudtMarius and others added 2 commits May 9, 2023 11:50

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

6841c3e

…ateSource # Conflicts: # CHANGELOG.md

Merge branch 'dev' into ms/#689-improving-implementation-of-ÍdCoordin…

ee15cf3

…ateSource

sebastian-peter reviewed May 15, 2023

View reviewed changes

docs/readthedocs/conf.py Outdated Show resolved Hide resolved

docs/readthedocs/conf.py Outdated Show resolved Hide resolved

sebastian-peter requested changes May 15, 2023

View reviewed changes

staudtMarius added 2 commits May 16, 2023 15:38

Implementing requested changes.

3a1142c

fmt

7e9c6e6

sebastian-peter approved these changes May 16, 2023

View reviewed changes

sebastian-peter merged commit 12616d1 into dev May 16, 2023

sebastian-peter deleted the ms/#689-improving-implementation-of-ÍdCoordinateSource branch May 16, 2023 13:52

SQL source for weather coordinates using PostGIS #694

SQL source for weather coordinates using PostGIS #694

Uh oh!

Conversation

staudtMarius commented Oct 27, 2022

Uh oh!

sonatype-lift bot commented Oct 27, 2022

Uh oh!

sebastian-peter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastian-peter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastian-peter commented Apr 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

staudtMarius commented May 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastian-peter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastian-peter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!