-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor data source to throw exception instead of returning optionals #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor data source to throw exception instead of returning optionals #712
Conversation
…ions-instead-of-returning-Optionals
src/main/java/edu/ie3/datamodel/exceptions/RawInputDataException.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/exceptions/RawInputDataException.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/712.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/712.diff | git apply Once you're satisfied commit and push your changes in your project. Footnotes |
Improving code. Fixing failing tests.
src/main/java/edu/ie3/datamodel/io/source/csv/CsvDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvDataSource.java
Outdated
Show resolved
Hide resolved
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
…ions-instead-of-returning-Optionals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments from my side :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we got it done! Thanks a lot @staudtMarius for this contribution, I think this improves usability of PSDM a lot!
Resolves #707