Skip to content

Refactor data source to throw exception instead of returning optionals #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

staudtMarius
Copy link
Member

Resolves #707

@staudtMarius staudtMarius added bug Something isn't working code quality Code readability or structure is improved labels Dec 15, 2022
@staudtMarius staudtMarius added this to the Version 3.0 milestone Dec 15, 2022
@staudtMarius staudtMarius self-assigned this Dec 15, 2022
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jan 19, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/712.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/712.diff | git apply

Once you're satisfied commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Improving code.
Fixing failing tests.
@staudtMarius staudtMarius marked this pull request as ready for review January 26, 2023 08:50
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments from my side :)

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we got it done! Thanks a lot @staudtMarius for this contribution, I think this improves usability of PSDM a lot!

@danielfeismann danielfeismann merged commit 8192a49 into dev Jul 26, 2023
@danielfeismann danielfeismann deleted the ms/#707-Refactor-data-sources-to-throw-exceptions-instead-of-returning-Optionals branch July 26, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality Code readability or structure is improved io Issues relating to input/output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor data sources to throw exceptions instead of returning Optionals
3 participants