Skip to content

Change from cleanup to cleanupSpec for BufferedCsvWriterTest #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

Change from cleanup to cleanupSpec for BufferedCsvWriterTest #907

merged 4 commits into from
Nov 2, 2023

Conversation

danielfeismann
Copy link
Member

resolves #809

@danielfeismann danielfeismann self-assigned this Oct 13, 2023
@danielfeismann danielfeismann added the test Related to tests label Oct 13, 2023
@danielfeismann
Copy link
Member Author

With respect to https://signalw.github.io/2018/09/07/setup-cleanup-order-in-spock.html this should be fine here

@danielfeismann danielfeismann mentioned this pull request Oct 13, 2023
Closed
@danielfeismann danielfeismann marked this pull request as ready for review October 13, 2023 12:35
sebastian-peter
sebastian-peter approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@sebastian-peter sebastian-peter merged commit e9cd2b0 into dev Nov 2, 2023
@sebastian-peter sebastian-peter deleted the df/#809_cleanup branch November 2, 2023 12:21
@sebastian-peter sebastian-peter added this to the Version 4.1 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@danielfeismann danielfeismann

Labels
test Related to tests
Projects
None yet
Milestone
Version 4.1
Development

Successfully merging this pull request may close these issues.

deleteRecursively sometimes fail on local machines
2 participants
@danielfeismann @sebastian-peter