Skip to content

Compare UUIDs instead of Strings. #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2023
Merged

Compare UUIDs instead of Strings. #932

merged 3 commits into from
Nov 21, 2023

Conversation

staudtMarius
Copy link
Member

Resolves #829

@staudtMarius staudtMarius added the code quality Code readability or structure is improved label Nov 20, 2023
@staudtMarius staudtMarius self-assigned this Nov 20, 2023
sebastian-peter
sebastian-peter requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny remarks from my side.

sebastian-peter
sebastian-peter approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@sebastian-peter sebastian-peter merged commit 751d01d into dev Nov 21, 2023
@sebastian-peter sebastian-peter deleted the ms/#829-compare-UUIDs-instead-of-Strings branch November 21, 2023 11:46
@sebastian-peter sebastian-peter added this to the Version 4.2 milestone Nov 28, 2023
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or structure is improved
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging this pull request may close these issues.

Compare UUIDs instead of Strings in EntitySource.findFirstEntityByUuid
2 participants
@staudtMarius @sebastian-peter