Skip to content

adapting storage input parameters #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 11, 2024
Merged

adapting storage input parameters #942

merged 21 commits into from
Jun 11, 2024

Conversation

SimonHuette
Copy link
Contributor

@SimonHuette SimonHuette commented Nov 27, 2023 •
edited
Loading

resolves #872

@SimonHuette SimonHuette added documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 27, 2023
@SimonHuette SimonHuette added this to the Version 4.2 milestone Nov 27, 2023
@SimonHuette SimonHuette self-assigned this Nov 27, 2023
@SimonHuette SimonHuette changed the title adapting dod in documentation adapting dod in documentation, fixing vn_simona config Nov 27, 2023
@SimonHuette SimonHuette changed the title adapting dod in documentation, fixing vn_simona config adapting dod in documentation Nov 27, 2023
sebastian-peter
sebastian-peter previously requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a line to the changelog here :)

@sebastian-peter
Copy link
Member

Sorry, I became a little doubtful of this effort once I looked deeper into it. Maybe we should discuss this once more. #872 (comment)

We could use this opportunity to fix the JavaDoc of StorageInput though, since it simultaneously declares the dod parameter to be the minimum as well as maximum permissible depth of discharge. I believe maximum is correct.

@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
@sebastian-peter
Copy link
Member

Postponed until we deal with storages in simona

@sebastian-peter sebastian-peter removed the good first issue Good for newcomers label Mar 21, 2024
@danielfeismann danielfeismann self-assigned this Apr 24, 2024
@SimonHuette
Copy link
Contributor Author

removed dod, lifetime, -cycle everywhere I could find

@danielfeismann
Merge branch 'refs/heads/dev' into sh/#872-storage-documentation
6b303ec 
# Conflicts:
#	CHANGELOG.md
#	docs/readthedocs/models/input/participant/storage.rst
#	src/main/java/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactory.java
#	src/test/groovy/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactoryTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTypeSourceTest.groovy
#	src/test/resources/edu/ie3/datamodel/io/source/csv/_types/storage_type_input.csv
@danielfeismann
remove more storage attributes which aren't used any longer
faa4715
@danielfeismann
recover storage input docs
2e2c9aa
@danielfeismann
Merge remote-tracking branch 'origin/sh/#872-storage-documentation' i…
06bd9d5 
…nto sh/#872-storage-documentation

# Conflicts:
#	docs/readthedocs/models/input/participant/storage.md
@danielfeismann
del storage.rst
34212c5
jo-bao
jo-bao requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small points

@danielfeismann danielfeismann requested a review from jo-bao June 10, 2024 11:26
jo-bao
jo-bao approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for me it's fine!

@danielfeismann danielfeismann merged commit 1c9ee34 into dev Jun 11, 2024
4 checks passed
@danielfeismann danielfeismann deleted the sh/#872-storage-documentation branch June 11, 2024 06:48
@sebastian-peter sebastian-peter changed the title adapting dod in documentation adapting storage input parameters Jun 11, 2024
@danielfeismann danielfeismann mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann left review comments

@jo-bao jo-bao jo-bao approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@danielfeismann danielfeismann

@SimonHuette SimonHuette

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Version 5.1
Development

Successfully merging this pull request may close these issues.

DOD Documentation for StorageInput is not clear
4 participants
@SimonHuette @sebastian-peter @danielfeismann @jo-bao