Skip to content

pp/#965 fix hyperlink in line documentation #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 5, 2024
Merged

pp/#965 fix hyperlink in line documentation #980

merged 14 commits into from
Jan 5, 2024

Conversation

pierrepetersmeier
Copy link
Contributor

Resolves #965
Should have worked so far @t-ober :).

Bild
Should something be linked here too?

@pierrepetersmeier pierrepetersmeier linked an issue Jan 4, 2024 that may be closed by this pull request
Fix Hyperlink in Line Documentation #965
Closed
@t-ober
Copy link
Contributor

t-ober commented Jan 5, 2024

!test

@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Jan 5, 2024
@sebastian-peter sebastian-peter added this to the Version 4.2 milestone Jan 5, 2024
@pierrepetersmeier
Copy link
Contributor Author

!test

sebastian-peter
sebastian-peter requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also do not forget to add a line to CHANGELOG.md. You can take the existing lines as a hint on how to do that. :)

sebastian-peter
sebastian-peter approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I just removed two more underscores that I just noticed.

@sebastian-peter sebastian-peter merged commit ff37f38 into dev Jan 5, 2024
@sebastian-peter sebastian-peter deleted the pp/#965-fix-hyperlink-in-line-documentation branch January 5, 2024 14:53
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@staudtMarius staudtMarius Awaiting requested review from staudtMarius

Assignees

@pierrepetersmeier pierrepetersmeier

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging this pull request may close these issues.

Fix Hyperlink in Line Documentation
3 participants
@pierrepetersmeier @t-ober @sebastian-peter