Skip to content

Fixing CsvSystemParticipantSourceTest #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed Couchbase integration tests that randomly failed [#755](https://github.com/ie3-institute/PowerSystemDataModel/issues/755)
- Fixed hyperlink in line documentation [#965](https://github.com/ie3-institute/PowerSystemDataModel/issues/965)
- Fixed some tests no failing when they should [#958](https://github.com/ie3-institute/PowerSystemDataModel/issues/958)

### Changed
- Changing from comparing strings to comparing uuids in `EntitySource.findFirstEntityByUuid` [#829](https://github.com/ie3-institute/PowerSystemDataModel/issues/829)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,10 @@ class CsvRawGridSourceTest extends Specification implements CsvTestDataMeta {

then: "everything is fine"
actualSet.size() == expectedSet.size()
actualSet.every {
it.success
}
def result = Try.scanCollection(actualSet, List)

actualSet.stream().map {
it.data.get()
}.toList().containsAll(expectedSet)
result.success
result.data.get().toList().containsAll(expectedSet)
}

def "The CsvRawGridSource is able to convert a stream of valid ConnectorInputEntityData to TypedConnectorInputEntityData"() {
Expand Down Expand Up @@ -260,12 +257,10 @@ class CsvRawGridSourceTest extends Specification implements CsvTestDataMeta {

then: "everything is fine"
actualSet.size() == expectedSet.size()
actualSet.every {
it.success
}
actualSet.stream().map {
it.data.get()
}.toList().containsAll(expectedSet)
def result = Try.scanCollection(actualSet, List)

result.success
result.data.get().toList().containsAll(expectedSet)
}

def "The CsvRawGridSource is able to add the third node for a three winding transformer to a stream of candidates"() {
Expand Down
Loading