Skip to content

Pp/#825 enhance documentation for csv timeseries #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 4, 2024

Conversation

pierrepetersmeier
Copy link
Contributor

@pierrepetersmeier pierrepetersmeier commented Jan 30, 2024

Resolves: #825

I also turned the gridtables here into listtables. I'm not entirely sure whether I understand the function of the uuid correctly here. Does the user have to enter a uuid here themselves or does our program itself have a function for this?

@pierrepetersmeier pierrepetersmeier linked an issue Jan 30, 2024 that may be closed by this pull request
@sebastian-peter
Copy link
Member

@pierrepetersmeier This is coninciding a bit with #997, so we should wait for that PR, which clears up questions regarding UUIDs (to your question, normally, the UUIDs are randomly generated for each result entity, but one can also explicitly set them).

@pierrepetersmeier
Copy link
Contributor Author

pierrepetersmeier commented Jan 30, 2024

@sebastian-peter Alright thanks

@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Jan 30, 2024
@sebastian-peter sebastian-peter self-requested a review February 1, 2024 18:42
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierrepetersmeier The PR I mentioned is merged, we could continue here :)

@pierrepetersmeier
Copy link
Contributor Author

Does everything look good or did i misunderstood something? @sebastian-peter

sebastian-peter
sebastian-peter previously approved these changes Mar 4, 2024
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sebastian-peter sebastian-peter merged commit 6129fa8 into dev Mar 4, 2024
@sebastian-peter sebastian-peter deleted the pp/#825-enhance-documentation-for-csv-timeseries branch March 4, 2024 10:58
@sebastian-peter sebastian-peter added this to the Version 5.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance documentation for CSV timeseries
3 participants