Skip to content

Increase code quality #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 7, 2022
Merged

Increase code quality #205

merged 8 commits into from
Jan 7, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 7, 2022

Resolves #203

@ckittl ckittl self-assigned this Jan 7, 2022
@ckittl ckittl added the bug Something isn't working label Jan 7, 2022
@ckittl ckittl changed the title Increas code quality Increase code quality Jan 7, 2022
@sonarqubegithubprchecks

This comment has been minimized.

3 similar comments
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@ckittl ckittl force-pushed the ck/#203-stepUpCodeQuality branch from c20396d to 30f5526 Compare January 7, 2022 10:57
@sonarqubegithubprchecks

This comment has been minimized.

ckittl added 2 commits January 7, 2022 12:44
... path from sonarqube settings, as currently scoverage is not working
@sonarqubegithubprchecks

This comment has been minimized.

@ckittl
Copy link
Member Author

ckittl commented Jan 7, 2022

Depends on #207, so close that one before!

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #205 (da5ebd8) into master (02a345c) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     44.66%   44.87%   +0.20%     
- Complexity      223      225       +2     
============================================
  Files            27       27              
  Lines          1350     1346       -4     
  Branches        177      177              
============================================
+ Hits            603      604       +1     
+ Misses          717      712       -5     
  Partials         30       30              
Impacted Files Coverage Δ
...ls/src/main/java/edu/ie3/util/EmpiricalRandom.java 75.86% <0.00%> (ø)
...utils/src/main/java/edu/ie3/util/geo/GeoUtils.java 15.81% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5271d07...da5ebd8. Read the comment docs.

@ckittl ckittl marked this pull request as ready for review January 7, 2022 14:59
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (42.30% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

@ckittl ckittl merged commit 7a972ec into master Jan 7, 2022
@ckittl ckittl deleted the ck/#203-stepUpCodeQuality branch January 7, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step up code quality
2 participants