Skip to content

Move qty rounding #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2022
Merged

Move qty rounding #315

merged 3 commits into from
Oct 23, 2022

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Oct 23, 2022

Resolves #314

@t-ober t-ober requested a review from danielfeismann October 23, 2022 10:41
@t-ober t-ober added the enhancement New feature or request label Oct 23, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 66.22% // Head: 66.22% // No change to project coverage 👍

Coverage data is based on head (57c0fbc) compared to base (b32a12c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #315   +/-   ##
=========================================
  Coverage     66.22%   66.22%           
  Complexity      231      231           
=========================================
  Files            40       40           
  Lines          1211     1211           
  Branches        117      117           
=========================================
  Hits            802      802           
  Misses          376      376           
  Partials         33       33           
Impacted Files Coverage Δ
.../scala/edu/ie3/util/quantities/QuantityUtils.scala 93.10% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 23, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

CHANGELOG.md Outdated
@@ -13,7 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed
- Refactored `GeoUtils`, moved them to the scala package and tailored them toward the `loactiontec.jts` Geometries used in the `OsmContainer` [#163] (https://github.com/ie3-institute/PowerSystemUtils/issues/163)
- Changed unit symbols according to DIN 1301-1 for apparent and reactive power [#278] (https://github.com/ie3-institute/PowerSystemUtils/issues/278)
- Changed unit symbols according to DIN 1301-1 for apparent and reactive power [#278] (https://github.com/ie3-institute/PowerSystemUtils/issues/278)qty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 80.00% Coverage (64.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danielfeismann danielfeismann merged commit 1bfea68 into main Oct 23, 2022
@danielfeismann danielfeismann deleted the to/#314-mv-qty-rounding branch October 23, 2022 11:32
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding for RichQuantities
3 participants